You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 6, 2019. It is now read-only.
Just cloned the latest bulkloader from master and it fails to build. This is directly related to the last pull request that added age range support. In the future please build and run the binary locally before submitting a PR. The following issue stops the build:
./main.go:286: not enough arguments in call to bulkloader.UploadResources
The text was updated successfully, but these errors were encountered:
Whoever reviews and merges a pull request should also test it to make sure it all works outside the creators dev environment. A pull request shouldn't be approved unless it works in other words.
@gregquinn2001, agreed - a lack of oversight on my part. After playing around locally and fixing the build I also discovered that the bulkloader is not compatible with the latest synthea output. Synthea is now on FHIR 1.8 and the bulkloader, gofhir server, and UI are still on FHIR 1.6. We'll need to coordinate updates to all of these tools.
Just cloned the latest bulkloader from master and it fails to build. This is directly related to the last pull request that added age range support. In the future please build and run the binary locally before submitting a PR. The following issue stops the build:
The text was updated successfully, but these errors were encountered: