Skip to content
This repository has been archived by the owner on Jun 6, 2019. It is now read-only.

Bulkloader Fails to Build #10

Open
cjduffett opened this issue Dec 22, 2016 · 3 comments
Open

Bulkloader Fails to Build #10

cjduffett opened this issue Dec 22, 2016 · 3 comments
Assignees

Comments

@cjduffett
Copy link
Contributor

Just cloned the latest bulkloader from master and it fails to build. This is directly related to the last pull request that added age range support. In the future please build and run the binary locally before submitting a PR. The following issue stops the build:

./main.go:286: not enough arguments in call to bulkloader.UploadResources
@gregquinn2001
Copy link
Collaborator

Whoever reviews and merges a pull request should also test it to make sure it all works outside the creators dev environment. A pull request shouldn't be approved unless it works in other words.

@cjduffett
Copy link
Contributor Author

@gregquinn2001, agreed - a lack of oversight on my part. After playing around locally and fixing the build I also discovered that the bulkloader is not compatible with the latest synthea output. Synthea is now on FHIR 1.8 and the bulkloader, gofhir server, and UI are still on FHIR 1.6. We'll need to coordinate updates to all of these tools.

@gregquinn2001
Copy link
Collaborator

Yes, we should log a separate github issue against SM for updating to FHIR 1.8.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants