Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some lines sould be removed in the cpp code #4

Open
deeperlearner opened this issue Aug 13, 2024 · 0 comments
Open

Some lines sould be removed in the cpp code #4

deeperlearner opened this issue Aug 13, 2024 · 0 comments

Comments

@deeperlearner
Copy link

deeperlearner commented Aug 13, 2024

My reference of skimage umeyama code is the following:
https://github.com/scikit-image/scikit-image/blob/main/skimage/transform/_geometric.py#L105

I think there are some confusing lines that should be corrected.
Line 101: T.rowRange(0, dim).colRange(0, dim) = U * V; This line should be removed.
Line 104: cv::Mat B = cv::Mat::zeros(3, 3, CV_8UC1);
Line 105: cv::Mat C = B.diag(0); What is the function of C? It is not mentioned later.
Line 112: cv::Mat res = U * twp; // U; res is not used.
Line 101, 104, 105, 112 should be removed.

@deeperlearner deeperlearner changed the title Some error in the cpp code: Some lines sould be removed in the cpp code Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant