You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think there are some confusing lines that should be corrected.
Line 101: T.rowRange(0, dim).colRange(0, dim) = U * V; This line should be removed.
Line 104: cv::Mat B = cv::Mat::zeros(3, 3, CV_8UC1);
Line 105: cv::Mat C = B.diag(0); What is the function of C? It is not mentioned later.
Line 112: cv::Mat res = U * twp; // U; res is not used.
Line 101, 104, 105, 112 should be removed.
The text was updated successfully, but these errors were encountered:
deeperlearner
changed the title
Some error in the cpp code:
Some lines sould be removed in the cpp code
Aug 15, 2024
My reference of skimage umeyama code is the following:
https://github.com/scikit-image/scikit-image/blob/main/skimage/transform/_geometric.py#L105
I think there are some confusing lines that should be corrected.
Line 101:
T.rowRange(0, dim).colRange(0, dim) = U * V;
This line should be removed.Line 104:
cv::Mat B = cv::Mat::zeros(3, 3, CV_8UC1);
Line 105:
cv::Mat C = B.diag(0);
What is the function of C? It is not mentioned later.Line 112:
cv::Mat res = U * twp; // U;
res is not used.Line 101, 104, 105, 112 should be removed.
The text was updated successfully, but these errors were encountered: