Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor HTML validation issue #14

Open
gmobrien opened this issue Mar 20, 2015 · 0 comments
Open

Minor HTML validation issue #14

gmobrien opened this issue Mar 20, 2015 · 0 comments

Comments

@gmobrien
Copy link

Hi there,

I came across SinglePaged today after struggling for a while on how to get my updated resume online. I'm very particular and I was about 30 minutes from breaking down and writing my own mini-CMS to handle it. Before I get into the bug report I just wanted to tell you that this is really fantastic and is almost exactly what I was looking for!

In any case, now that I have the rough skeleton of my site online I noticed there's a validation error in the the HTML on the page when the Google API key is included. The JS at the bottom of the page gets loaded outside the body tag and therefore is invalid. The fix is trivial and I made it already on my copy but I wanted to let you know upstream since it was the only issue I came across.

The last 4 lines of index.html should read:

{% include analytics.html %}
<script src="//ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
<script src="site.js"></script>
</body>
</html>

I'd have created a patch but I figured it was would be more effort for you!

cheers,
Gabriel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant