Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asXML -indentAttrs -innerXML #24

Open
heinrichmartin opened this issue Mar 10, 2016 · 3 comments
Open

asXML -indentAttrs -innerXML #24

heinrichmartin opened this issue Mar 10, 2016 · 3 comments

Comments

@heinrichmartin
Copy link

I have just found patches that I might not have shared yet. I am working with pristine sources, so I can provide patches as-is. Sorry for not making it pull requests.

I am quite sure that the patch for -indentAttrs is not taken from the indentAttrs branch. If I recall wrong, then credits to those who contributed. I still include both patches as my -innerXML comes after -indentAttrs in my spec file.

Github does not allow .patch files. I renamed them to .patch.txt:
tdom-0.8.2-indentAttrs.patch.txt
tdom-0.8.2-innerXML.patch.txt

@heinrichmartin
Copy link
Author

Note, that my -indentAttrs takes an argument that is used as the indentation level (mirroring -indent).

@pointsman
Copy link
Member

This is an old, currently not updated mirror. The real thing (see http://core.tcl.tk/tdom/timeline) has -indentAttrs since a year or so.

Could you please provide a patch against this for your -innerXML code?

@kolewu
Copy link

kolewu commented Mar 18, 2016

Oha, good to know -- thanks Rolf.

And what about the homepage http://tdom.github.io/? I have provided a pull request to fix the wrong encoding some time ago: https://github.com/tDOM/tdom.github.com/pull/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants