Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors are lost/changed after restarting FF #3

Open
ThomasMcA opened this issue Mar 24, 2015 · 3 comments
Open

Colors are lost/changed after restarting FF #3

ThomasMcA opened this issue Mar 24, 2015 · 3 comments

Comments

@ThomasMcA
Copy link

I'm using tab-highlighter 0.2.3 with tabkit 2e 0.12.0 in FF 35.0.1 in 32bit Win7 Pro SP1.
I have over 200 inactive tabs, with several tab groups that are already being colorized by tab-highlighter. Whenever I create a new colorized group, the colors are forgotten after FF restarts. Not only are they forgotten, but they are outright changed. For example, a group of 25 tabs that start as one color might become 3 groups after I restart FF. Even if I ungroup, then move a few tabs around, then regroup, the problem still happens after restarting FF.

@PikachuEXE
Copy link
Member

This is due to how session store works in Firefox
If a tab is unloaded, setting attributes on it won't be remembered
So if you have some load tabs & unloaded tabs and you try to change the group (or ungroup),
the result for loaded tabs will be remembered, while those for unload tabs will be discarded (after restart)

I don't have a solution for this issue yet
Force loading all affected tabs is not good for performance.

Try to load all related tabs and change the group / ungroup those tabs to see if that solves your problem
I might need to add some note / warning for that situation

@ThomasMcA
Copy link
Author

If force loading all affected tabs would fix the problem, but is bad for performance, then why not just warn the user about it? A slow solution is better than a broken app. Just display an explanatory popup, include a "don't remind me again" checkbox, and take all the time you need.

@PikachuEXE
Copy link
Member

That works too, but I guess I would let user to do what needs to be done.

tabkit/tabkit2#83 opened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants