-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace dependency on dartsass-ruby with sass-embedded #2
Labels
help wanted
Extra attention is needed
Comments
This is done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As per this thread, the dartsass-ruby gem is a compatibility shim which provides legacy SassC features on Dart Sass.
When Dart Sass 2.0 is released, many of these features will become impossible to support.
Therefore, we should get rid of the dartsass-ruby dependency and replace it with a direct integration to sass-embedded. This involves generally replacing any references to the
::SassC
namespace. The sass-embedded documentation is here.To recap:
Current dependency pattern: dartsass-sprockets --> dartsass-ruby --> sass-embedded
Future dependency pattern: dartsass-sprockets --> sass-embedded
A PR would be welcome for this.
The text was updated successfully, but these errors were encountered: