Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datepicker to Storybook #1239

Open
Traxmaxx opened this issue Nov 27, 2023 · 6 comments
Open

Add datepicker to Storybook #1239

Traxmaxx opened this issue Nov 27, 2023 · 6 comments

Comments

@Traxmaxx
Copy link
Contributor

Traxmaxx commented Nov 27, 2023

Add datepicker to Storybook so it is properly documented!

Screenshot 2023-11-27 at 13 00 48

https://www.figma.com/file/eq3JgvmW48IVrYcg2kzgLL/Komiser---Design-System?type=design&node-id=1856-12529&mode=dev

You will find a short intro into our Storybook setup in the Dashboard README

@umrkhn
Copy link
Contributor

umrkhn commented Nov 29, 2023

@Traxmaxx assign please.

@AllieMendes
Copy link
Collaborator

I've assigned it to you @umrkhn and left a comment on Figma, let me know if you have any questions or suggestions on how we can improve the component!

@umrkhn
Copy link
Contributor

umrkhn commented Nov 30, 2023

@AllieMendes I couldn't find the code related to the date-picker component can you guide me ?

@AllieMendes
Copy link
Collaborator

I believe the component doesn't exist, it must be created and added to storybook
Can you please confirm @Traxmaxx?

@Traxmaxx
Copy link
Contributor Author

Traxmaxx commented Dec 5, 2023

Woops, I didn't check ninitially and presumed it's existing already. Sorry for the confusion. @AllieMendes do you think it makes sense to add it or is the datepicker obsolete for the forseeable future?
@umrkhn depending on the answer to aboves question I can create a separate issue for initially creating the datepicker or I update this one to include that task as well and will pull the specs from figma for you.

@AllieMendes
Copy link
Collaborator

Thank you for checking @Traxmaxx. I think it makes sense as there has been this issue for a long time that uses it: #854
The designs are on Figma for the context, so if you want to create the datepicker component @umrkhn we could finally use it on issues like these :)

@umrkhn umrkhn removed their assignment May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants