Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(readme): do not add patch version if it wasn't present #23

Open
sheerlox opened this issue Nov 23, 2023 · 0 comments
Open

fix(readme): do not add patch version if it wasn't present #23

sheerlox opened this issue Nov 23, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@sheerlox
Copy link
Member

Description

The current implementation of the readme updater adds the patch version where it wasn't present.

Given the ~> operator's behavior is dependent on whether the patch is present or not, adding the patch version changes the meaning of the version requirement where the ~> operator is used.

Expected Behavior

~> MAJOR.MINOR should be updated to ~> MAJOR.MINOR

Actual Behavior

~> MAJOR.MINOR is updated to ~> MAJOR.MINOR.PATCH

Possible Fix

No response

Steps to Reproduce

Run semantic-release-hex on a repository with a ~> MAJOR.MINOR version requirement in the README.

Context

Related:

Your Environment

  • semantic-release-hex version: v1.1.0
  • NodeJS version: N/A
  • Operating System and version: N/A
  • TypeScript version (if applicable): N/A
  • Link to your project (if applicable): N/A
@sheerlox sheerlox added the bug Something isn't working label Nov 23, 2023
@sheerlox sheerlox self-assigned this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant