Real time map #299
Merged
Real time map #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladbyk89
requested changes
Aug 13, 2024
Comment on lines
89
to
97
| unsubscribe = await listenToChildStatements(dispatch, statement.statementId, (childStatements) => { | ||
| setSubStatements(childStatements); | ||
|
|
||
| const topResult = sortStatementsByHirarrchy([ | ||
| statement, | ||
| ...childStatements.filter((state) => isOptionFn(state) || state.statementType === StatementType.question), | ||
| ])[0]; | ||
|
|
||
| setResults(topResult); |
There was a problem hiding this comment.
Create the callback function outside of the listenToChildStatements props to improve readability.
No it doesn't work properly yet, I've asked for Tal's advice in what should i do in order for it to work. The problem is that when we add a new statement only the new statement is added in real time, the whole map is somehow missing and only on second rendering we get the expected result like before. |
|
Lets talk about it today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Real time map changes (still not finished)