-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The with-cache macro is marked private #175
Comments
@scarytom Hi Tom, I'm happy to make this public on the next release - just want to clean up some of the docs, and consider final changes before potentially marking the feature as non-experimental. I'm curious, could you share a little about your use case for the cache feature? |
No problem, I'm hoping to use nippy to deserialise input-streams directly from S3, so that I don't have to hold all the bytes in memory before deserialisation. I'm using Lines 1780 to 1781 in 5a9a391
I'm slightly curious why there isn't a thaw function that accepts an input-stream (and a corresponding freeze function that takes an output-stream). |
The call to
No particular reason, happy to look at a PR if you'd like to add something. Would just note that in general I'd recommend using the standard freeze (with header) unless you have a strong reason not to. The header can be important for portability, esp. if you're dealing with long-lived data. |
Well, we aren't using the cache feature yet, so this issue might be moot. I couldn't immediately see how to call the standard freeze (with header) with an output-stream (nor standard thaw on an input-stream). |
The
with-cache
macro is marked as private, but, as the docstring says, users may wish to call it if they are usingfreeze-to-out!
orthaw-from-in!
. Is there any harm in making this macro public?nippy/src/taoensso/nippy.clj
Lines 972 to 976 in 5a9a391
The text was updated successfully, but these errors were encountered: