-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: spawn /Applications/Firefox.app/Contents/MacOS/firefox-bin ENOENT #125
Comments
Thanks; even though the repo's gone, I can reconstruct it and update the npm package if @bcomnes wouldn't mind adding me as an npm owner? |
Sure no problem. Which one? I’m out right now but will set a reminder for when I’m back to my keys. |
@bcomnes awesome! |
@ljharb In case you don't have an up-to-date clone, there's a partial Git history at https://github.com/bcomnes/browser-launcher that may be salvageable. It doesn't cover 2.0.0-4.0.0 but may be worth using as a start to preserve various commit messages and author attribution of merged PRs until that point. I imagine you'll get the rest from npm release tarballs? |
Incredible, I found the old full source tree on my laptop. |
I have no clue what GitHub did but they re-attached my fork to some random other repo. I'm going rename the forked version and create a new one and push up the tree. |
Ok I just performed the following:
|
Thanks, if you'd mind bouncing it into I can certainly publish a v5 if you want, but a change of owner doesn't usually warrant a major release - is that necessary? (note https://majors.nullvoxpopuli.com/q?minors=false&old=false&packages=browser-launcher - most users are on v1 and v3, so being able to publish bugfixes to them is pretty important) |
Thanks! |
As of Firefox 121 (released Dec 2023), Mozilla no longer includes a
firefox-bin
inside the bundle for macOS.The good news is that the replacement,
firefox
has been around for 10+ years. So it is safe to change this.Prior art:
firefox-bin
tofirefox
karma-runner/karma-firefox-launcher#330The problem originates in the browser-launcher dependency, but I'm reporting it here because that package no longer has a source or issue tracker since https://github.com/substack account was deleted.
pass.js:
package.json:
The text was updated successfully, but these errors were encountered: