-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure/detailed balance foundation #2770
Restructure/detailed balance foundation #2770
Conversation
…ace.py, transport_montecarlo_numba_interface.py, conftest.py, formal_integral.py, base.py, and macro_atom.py
Tests rely on tardis-sn/tardis-regression-data#24 merging first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this, but I have also done a lot of work on it so it needs other reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell it looks fine, but it's always hard to tell with the restructure PRs which parts are renames or functional changes worth paying attention to, or are just files and functions being moved around to places that make more sense.
In this case @jvshields I think the tests are most illustrative because we compare this new structure with the previous way(s) of doing things. |
Tests are now failing for a different but related reason. |
…e population solvers
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2770 +/- ##
==========================================
- Coverage 70.87% 70.70% -0.17%
==========================================
Files 209 213 +4
Lines 15589 15823 +234
==========================================
+ Hits 11049 11188 +139
- Misses 4540 4635 +95 ☔ View full report in Codecov by Sentry. |
No description provided.