Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Fixes #2884

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Release Fixes #2884

merged 3 commits into from
Nov 18, 2024

Conversation

atharva-2001
Copy link
Member

📝 Description

Type: 🪲 bugfix | 🚀 feature | ☣️ breaking change | 🚦 testing | 📝 documentation | 🎢 infrastructure

Tasks Done:

  • Move pre release jobs to the release workflow
  • Fix the changelog release date

Working changelog: https://github.com/atharva-2001/tardis/actions/runs/11852469074

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@tardis-bot
Copy link
Contributor

tardis-bot commented Nov 15, 2024

*beep* *bop*
Hi human,
I ran ruff on the latest commit (cc4424b).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

7	W293  	[*] Blank line contains whitespace
4	RET505	[ ] Unnecessary `else` after `return` statement
3	E999  	[ ] SyntaxError: Expected an expression
1	RET506	[ ] Unnecessary `else` after `raise` statement
1	E902  	[ ] No such file or directory (os error 2)
1	W291  	[*] Trailing whitespace
1	W292  	[*] No newline at end of file
1	F811  	[ ] Redefinition of unused `opacity_state_initialize` from line 13

Complete output(might be large):

.github/workflows/post-release.yml:7:4: E999 SyntaxError: Expected an expression
.github/workflows/post-release.yml:124:37: W291 [*] Trailing whitespace
.github/workflows/pre-release.yml:1:1: E902 No such file or directory (os error 2)
.github/workflows/release.yml:7:4: E999 SyntaxError: Expected an expression
.github/workflows/release.yml:93:1: W293 [*] Blank line contains whitespace
.github/workflows/release.yml:96:1: W293 [*] Blank line contains whitespace
.github/workflows/release.yml:103:1: W293 [*] Blank line contains whitespace
.github/workflows/release.yml:106:1: W293 [*] Blank line contains whitespace
.github/workflows/release.yml:109:1: W293 [*] Blank line contains whitespace
.github/workflows/release.yml:114:1: W293 [*] Blank line contains whitespace
.github/workflows/release.yml:118:1: W293 [*] Blank line contains whitespace
.github/workflows/release.yml:142:23: W292 [*] No newline at end of file
.mailmap:1:38: E999 SyntaxError: Expected an expression
tardis/spectrum/formal_integral.py:23:5: F811 Redefinition of unused `opacity_state_initialize` from line 13
tardis/spectrum/formal_integral.py:340:13: RET506 Unnecessary `else` after `raise` statement
tardis/spectrum/formal_integral.py:681:5: RET505 Unnecessary `else` after `return` statement
tardis/spectrum/formal_integral.py:717:5: RET505 Unnecessary `else` after `return` statement
tardis/spectrum/formal_integral_cuda.py:375:5: RET505 Unnecessary `else` after `return` statement
tardis/spectrum/formal_integral_cuda.py:420:5: RET505 Unnecessary `else` after `return` statement
Found 19 errors.
[*] 9 fixable with the `--fix` option.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.87%. Comparing base (763c11d) to head (cc4424b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2884      +/-   ##
==========================================
- Coverage   70.22%   69.87%   -0.36%     
==========================================
  Files         214      214              
  Lines       15981    15981              
==========================================
- Hits        11223    11166      -57     
- Misses       4758     4815      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tardis-bot
Copy link
Contributor

tardis-bot commented Nov 15, 2024

*beep* *bop*
Hi human,
I ran benchmarks as you asked comparing master (83282e3) and the latest commit (cc4424b).
Here are the logs produced by ASV.
Results can also be downloaded as artifacts here.

Significantly changed benchmarks:

All benchmarks:

Benchmarks that have stayed the same:

| Change   | Before [6ee870e0] <master>   | After [cc4424ba]    | Ratio   | Benchmark (Parameter)                                                                                                               |
|----------|------------------------------|---------------------|---------|-------------------------------------------------------------------------------------------------------------------------------------|
|          | 2.75±0.4ms                   | 5.47±0.8ms          | ~1.99   | transport_montecarlo_single_packet_loop.BenchmarkTransportMontecarloSinglePacketLoop.time_single_packet_loop                        |
|          | 2.82±0.02ms                  | 3.91±0.02ms         | ~1.39   | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('scatter')                                     |
|          | 48.7±30μs                    | 58.2±60μs           | ~1.19   | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_scatter                                          |
|          | 2.14±2μs                     | 1.93±1μs            | ~0.90   | transport_montecarlo_estimators_radfield_estimator_calcs.BenchmarkMontecarloMontecarloNumbaPacket.time_update_line_estimators       |
|          | 4.24±0.5μs                   | 3.36±0.5μs          | ~0.79   | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_within_shell                              |
|          | 43.7±20μs                    | 22.2±5μs            | ~0.51   | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_last_interaction_tracker_list |
|          | 471±200ns                    | 511±100ns           | 1.08    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation                                      |
|          | 206±0.4ns                    | 222±0.04ns          | 1.08    | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_intensity_black_body                                       |
|          | 561±200ns                    | 592±100ns           | 1.06    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_photoabsorption_opacity_calculation                              |
|          | 561±200ns                    | 591±100ns           | 1.05    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_pair_creation_opacity_calculation                                |
|          | 1.15±0μs                     | 1.21±0μs            | 1.05    | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_boundary                |
|          | 710±2ns                      | 734±0.3ns           | 1.03    | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_thomson_scatter                                       |
|          | 3.61±0ms                     | 3.68±0ms            | 1.02    | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('macroatom')                                   |
|          | 41.5±20μs                    | 42.3±30μs           | 1.02    | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_emission                                         |
|          | 1.08±0m                      | 1.09±0m             | 1.01    | run_tardis.BenchmarkRunTardis.time_run_tardis_rpacket_tracking                                                                      |
|          | 30.8±0.05μs                  | 31.2±0.09μs         | 1.01    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list                  |
|          | 3.19±0.5μs                   | 3.22±0.7μs          | 1.01    | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_bad_vpacket                                       |
|          | 2.08±0m                      | 2.09±0m             | 1.00    | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_FormalIntegrator_functions                                 |
|          | 40.8±0.04s                   | 40.5±0.02s          | 0.99    | run_tardis.BenchmarkRunTardis.time_run_tardis                                                                                       |
|          | 63.4±0.01ms                  | 62.7±0.2ms          | 0.99    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_rpacket_trackers_to_dataframe                  |
|          | 1.69±0ms                     | 1.64±0.04ms         | 0.98    | transport_montecarlo_main_loop.BenchmarkTransportMontecarloMontecarloMainLoop.time_montecarlo_main_loop                             |
|          | 6.24±0.7μs                   | 5.92±1μs            | 0.95    | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket                                           |
|          | 7.42±2μs                     | 7.03±2μs            | 0.95    | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_volley                                    |
|          | 1.87±0.02μs                  | 1.72±0.4μs          | 0.92    | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_line                    |

If you want to see the graph of the results, you can check it here

@andrewfullard andrewfullard merged commit 6ee870e into tardis-sn:master Nov 18, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants