Test CI on #45 #50
Merged
Test CI on #45 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The command line changes are nontrivial in that they cannot be expressed with usual `Cmdliner` combinators. Attaching is done with an `--attach` option that is incompatible with the normal `EXECUTABLE` arguments - `EXECUTABLE` is now a sequence of arguments, rather than a single space-separated one. This makes the above mutual exclusion slightly easier to represent, and is more in-line with existing tools (`perf`, `gdb --args`). - `Unix.kill pid 0` is used to check if the process is alive, (since `wait` can only be used for child processes), this is valid and intended usage according to the POSIX specification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of - Allow olly to attach to an external process #45