Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extendable Configuration #79

Open
mike4git opened this issue Aug 10, 2024 · 1 comment
Open

Extendable Configuration #79

mike4git opened this issue Aug 10, 2024 · 1 comment

Comments

@mike4git
Copy link
Collaborator

mike4git commented Aug 10, 2024

We need the Configuration of this bundle being extendable
so that other bundles can add or create their specific Converters and Populators
and offer them to be configured below Configuration key:

neusta_converter.

Concrete scenario

The pimcore-converter-bundle offers a LocalizedPropertyMappingPopulator which could be configured as simple as PropertyMappingPopulator.

So in the same way, it would be nice to just write in a Converter configuration:

neusta_converter:
  converter:
    my.converter:
      target: App\MyView
      properties:
        attribute1: srcAttribute1
        ...
+     localized_properties:
+       localizedAttribute1: srcLocalizedAttribute1

To allow that, a lot more things have to be prepared in converter-bundle Configurationclass.

@jdreesen
Copy link
Member

jdreesen commented Aug 12, 2024

I think we should use #41 as a base for this, as it already allows extending the config at certain points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants