Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] loosen subjkt name constraints #304

Open
melMass opened this issue Jun 7, 2023 · 1 comment
Open

[feat] loosen subjkt name constraints #304

melMass opened this issue Jun 7, 2023 · 1 comment

Comments

@melMass
Copy link
Member

melMass commented Jun 7, 2023

Describe the problem

When reading #303 I asked myself why those constraints actually exist (no capital or spaces in SUBJKT names).

IIRC this was inherited from HEN but in HEN early days those constraint did not exist.

After a bit of debugging and discussions on discord.
We realized that:

  • There is no check for the name on string, wild stuff are allowed:
    • quotes (like literal quotes this is not an empty string) :
      image
    • empty string and non url friendly characters:
      image
    • emojis (still have to debug that to understand it better)
      image

Describe the solution you'd like

Allowing spaces and capitals in names but keep the a-z-A-Z-0-9 constraints

Alternatives considered

No response

Additional context

No response

@Zir0h
Copy link
Contributor

Zir0h commented Oct 28, 2023

woops, forgot about allowing the spaces, but uppercase is allowed again via #349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants