-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git-clone unintended interaction with basic-auth workspace when using ssh directory workspace #1186
Comments
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
We now use a work-around where we don't use the ssh-directory type of secrets when we need to have a basic-auth. So I regretfully don't have the reproduction configured to just run it and see if it still fails, but since the file (Task git-clone.yaml) has not been updated since I'm assuming it still fails. |
Expected Behavior
When only binding to the ssh-directory (and output) workspaces the git-clone task should not fail because the basic-auth workspace is bound to the PipelineRun (but not to the git-clone Task).
Actual Behavior
We get an error:
Somehow the following line in the git-clone evaluates to true even though we didn't bind the basic-auth workspace to the task:
In the error you can also so that even though
WORKSPACE_BASIC_AUTH_DIRECTORY_BOUND
evaluates to true thatWORKSPACE_BASIC_AUTH_DIRECTORY_PATH
is empty.Steps to Reproduce the Problem
I'll omit company and unrelated stuff, and try to just show the setup that leads to this error.
We're running from GitHub with pipelinesascode, but I think it is a generic issue.
As you can see we have one git-clone task bound to
ssh-directory
and another git-clone task bound tobasic-auth
.Additional Info
ssh-directory
workspace and completely removing thebasic-auth
workspace from our Pipeline.app-git-clone
bound only tobasic-auth
uses something fromssh-directory
. This gives us the following error:Thank you for looking into this.
The text was updated successfully, but these errors were encountered: