Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventListener parameters #1862

Open
JuMasta opened this issue Nov 21, 2023 Discussed in #1803 · 5 comments
Open

EventListener parameters #1862

JuMasta opened this issue Nov 21, 2023 Discussed in #1803 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@JuMasta
Copy link

JuMasta commented Nov 21, 2023

Discussed in #1803

Originally posted by JuMasta October 24, 2023
Hi!
We use Tekton-operator v0.68.0 version. Can I set parameters kube-api-burst and kube-api-qps to EventListener via TektonConfig or any other way. When EventListener gets 2 webhooks at the same time it gets error - "error getting secret: client rate limiter Wait returned an error: rate: Wait(n=1) would exceed context deadline".

@jkandasa
Copy link
Member

@JuMasta do you want to control tekton-events-controller things? Could you please elaborate the deployments details that you want to manage?

@JuMasta
Copy link
Author

JuMasta commented Nov 24, 2023

I want to manage by EventListener deployment. My log: {"severity":"info","timestamp":"2023-11-23T14:43:28.205Z","logger":"eventlistener","caller":"sink/sink.go:420","message":"interceptor stopped trigger processing: rpc error: code = FailedPrecondition desc = error getting secret: client rate limiter Wait returned an error: rate: Wait(n=1) would exceed context deadline","commit":"","eventlistener":"github-listener-interceptor","namespace":"tekton-pipelines","/triggers-eventid":"0569848a-8c88-4c13-91c0-bea091ae72dc","eventlistenerUID":"0766dc4d-6653-4b69-83d1-32046cec7292","/triggers-eventid":"0569848a-8c88-4c13-91c0-bea091ae72dc","/trigger":""}

@jkandasa
Copy link
Member

jkandasa commented Jan 21, 2024

@JuMasta sorry for the late response, Does operator manages EventListener? I guess trigger is managed by operator and EventListener is managed by triggers controller. Am I correct?
AFAIK, we can control triggers controller kube-api-burst and kube-api-qps via options https://tekton.dev/docs/operator/tektonconfig/#additional-fields-as-options

@JuMasta
Copy link
Author

JuMasta commented Feb 15, 2024

You are correct. I can set these parameters via options to triggers-controller, but I can't find a way to set these parameters to EventListener

@jkandasa jkandasa added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 15, 2024
@jkandasa
Copy link
Member

Thanks @JuMasta !
@savitaashture Is it possible to control the EventListeners deployment parameters with triggers-controller's deployment parameters or with a configMap?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants