Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Expand all transaction data #749

Open
donnyquixotic opened this issue Aug 18, 2023 · 2 comments
Open

Feature Request - Expand all transaction data #749

donnyquixotic opened this issue Aug 18, 2023 · 2 comments
Labels
🎯 Feature New feature 🔬 Needs Grooming Further information is required

Comments

@donnyquixotic
Copy link
Contributor

donnyquixotic commented Aug 18, 2023

Feature: Toggle All Transaction Data in TX Table

Overview

Implement a "Toggle All" feature for transaction data in the TX table, allowing users to expand or collapse all transaction data simultaneously.

Example of an action that is truncated and there is no way to view the full data: https://explorer-test.telos.net/transaction/712d8c06109bfcb5d93d4f84a08d5eee9ef19898fbdebfc168be866cd7053881

Current Behavior

  • Transaction data in the TX table is initially collapsed.
  • Users can expand or collapse individual rows of transaction data.
  • User selections are not remembered upon navigation.

Desired Behavior

  • Add a toggle feature in the "Data" header of the TX table.
  • Use chevron icons to indicate expand/collapse state.
  • Allow users to expand or collapse all transaction data with a single action.
  • Remember the last user selection for the global toggle.

Detailed Requirements

Toggle Functionality

  1. Add a chevron icon in the "Data" header of the TX table.
  2. Clicking the chevron should toggle all transaction data:
    • Chevron pointing down: expand all data
    • Chevron pointing up: collapse all data

Default State

  • By default, all transaction data should be collapsed.
  • The chevron should initially point downward.

User Interactions

  • Clicking the chevron when pointing down should expand all data rows.
  • Clicking the chevron when pointing up should collapse all data rows.
  • Users can still expand or collapse individual data rows.

State Management

  • The global toggle state (expanded/collapsed) should be remembered across navigation.
  • Individual row states should not be remembered across navigation.
  • If any individual rows are manually expanded/collapsed, the chevron state should remain unchanged.

Chevron State

  • The chevron will always be pointing either up or down, indicating the action that will occur when clicked.
  • Chevron pointing down: clicking will expand all rows
  • Chevron pointing up: clicking will collapse all rows
  • The chevron state is not affected by individual row expansions/collapses

Acceptance Criteria

  1. The "Data" header includes a clickable chevron icon.
  2. Clicking the chevron expands or collapses all transaction data.
  3. The chevron icon changes direction based on the current global state.
  4. The global toggle state is remembered across page navigation.
  5. Individual row expansions/collapses do not affect the global toggle state or chevron direction.
  6. The feature works correctly with varying amounts of data in the table.
  7. Add tooltip to chevron explaining actions : "Collapse Data", "Expand Data"
@donnyquixotic donnyquixotic added 🔬 Needs Grooming Further information is required 🎯 Feature New feature ✨ Enhancement Improvements on existing features and removed 🎯 Feature New feature ✨ Enhancement Improvements on existing features labels Aug 18, 2023
@kylanhurt
Copy link
Contributor

And I assume this option would be somewhere right above the table in this area?
image

@donnyquixotic
Copy link
Contributor Author

donnyquixotic commented Nov 12, 2023

And I assume this option would be somewhere right above the table in this area? image

Yea, a toggle should do the trick. There's a related bug where if you expand one row, that row remains expanded on data update and/or page navigation. We want the following behavior:

  • on expand row, disable live transactions (if enabled and on front page)
  • collapse rows if on first page and live transactions is toggled on again
  • collapse rows on page navigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 Feature New feature 🔬 Needs Grooming Further information is required
Projects
None yet
Development

No branches or pull requests

2 participants