Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: disable codecov on patch case that causes some wrong results #449

Open
4 tasks
jaybxyz opened this issue Oct 5, 2021 · 0 comments · May be fixed by #451
Open
4 tasks

feat: disable codecov on patch case that causes some wrong results #449

jaybxyz opened this issue Oct 5, 2021 · 0 comments · May be fixed by #451
Assignees
@jaybxyz
Labels
devops installation, deployment, node operation wontfix This will not be worked on

Comments

@jaybxyz
Copy link
Contributor

jaybxyz commented Oct 5, 2021

Summary

This issue doesn't request to remove the whole code coverage. This issue requests to remove codecov/patch part since it is unreliable and it presents weird behaviour from time to time. From our experience, it doesn't count certain lines although the lines are covered from the test codes. This results in decreasing code coverage percentage.

Proposal

Let's disable codecov patch

References

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@jaybxyz jaybxyz added enhancement New feature or request devops installation, deployment, node operation labels Oct 5, 2021
@jaybxyz jaybxyz self-assigned this Oct 5, 2021
@jaybxyz jaybxyz removed the enhancement New feature or request label Oct 5, 2021
@jaybxyz jaybxyz linked a pull request Oct 6, 2021 that will close this issue
Open
10 tasks
@dongsam dongsam changed the title feat: disable codecov on patch feat: disable codecov on patch case that causes some wrong results Oct 7, 2021
@dongsam dongsam added the wontfix This will not be worked on label Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaybxyz jaybxyz

Labels
devops installation, deployment, node operation wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: disable codecov on patch case that causes some wrong results b-harvest/liquidity
2 participants
@dongsam @jaybxyz