Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using hosted configuration, the configuration will never be deployed. #31

Open
amitla opened this issue Nov 26, 2023 · 0 comments
Open

Comments

@amitla
Copy link

amitla commented Nov 26, 2023

Description

consider this snippet:

module "appconfig" {
  source  = "terraform-aws-modules/appconfig/aws"
  version = "~> 1.0"

  name                                = "some-name"
  description                       = "AppConfig hosted configuration for some-name"
  config_profile_name               = title(var.environment)
  create_deployment_strategy        = false
  deployment_strategy_id            = "AppConfig.AllAtOnce"

  environments = {
    "${var.environment}" = {
      name        = "${title(var.environment)}"
      description = "${title(var.environment)} environment"
    }
  }

  use_hosted_configuration           = true
  hosted_config_version_content_type = "application/json"
  hosted_config_version_content      = file("${path.module}/configs/${var.environment}/config.json")
  
  tags = var.tags
}
  • [v] ✋ I have searched the open/closed issues and my issue is not listed.

Versions

  • Module version [Required]: 1.1.4 (note - this will reproduce on 2.0.0 as well)

Reproduction Code [Required]

see above

Steps to reproduce the behavior:
run init and plan, examine the output

Expected behavior

Expecting the deployment step to take place.

Actual behavior

Deployment is not in the plan

Terminal Output Screenshot(s)

Additional context

This issue was introduced in the 1.1.4 version via this PR: terraform-aws-modules/terraform-aws-appconfig#7
The fix should take into account the use_hosted_configuration flag and allow the code in the aws_appconfig_deployment resource to run even if deployment_configuration_version is not set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant