-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad Default: Assembly.getArea() is 1.0 #1682
Comments
I say make it |
This might be one of those "not all things in the composite pattern" should be implemented kind of thing. I'd be careful with areas though. Typically you make a composite and then add things to it. Not sure if it should be |
armi/armi/reactor/assemblies.py Lines 274 to 278 in f5fd79b
I'd say |
Over on this PR, I noted a strange point in the ARMI API.
When an
Assembly
has no children/Blocks
, this method returns a "default area" of1.0
. Surely that should be an error? Or it should returnNone
. Or it should return0.0
. Returning a valid numerical value just seems crazy.armi/armi/reactor/assemblies.py
Lines 274 to 278 in f5fd79b
The text was updated successfully, but these errors were encountered: