-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove silent overwriting of shutil.copy
in ARMI utils
#1690
Comments
I agree, silently over-writing a standard library tool whenever you I would say "let's do it right now!", but since it's an API-breaking change, we will be slow and deliberate. @drewj-usnctech Just FYI. |
this seems super low priority. I agree it is confusing and surprising but its going to be a lot of work to change and very little benifit. |
Thanks for reopening @onufer I grepped around and it won't be a huge lift. I agree it's low priority, but I'd like to get in the habit of paying back some tech debt and this is an easy one. |
safeCopy
silently overwritesshutil.copy
in ARMI:armi/armi/utils/__init__.py
Lines 845 to 847 in aa758f3
I'm making this ticket so that when
shutil.copy
is replaced in all downstream plugins withsafeCopy
, I want to remove this menace from the code base.I also need to check in with other ARMI users so they have a heads up on a potentially breaking change (so, if shutil is being leveraged, they can do nothing and revert to the real
shutil.copy
, or they can also swap to explicitly usingsafeCopy
)The text was updated successfully, but these errors were encountered: