Check on snapshot DB name is not smart

[keckler]

There is a settings validator that checks the name of the database being used in a snapshot run:

armi/armi/operators/settingsValidation.py

Lines 450 to 459 in f9903fe

	self.addQuery(
	lambda: self.cs.caseTitle.lower()
	== os.path.splitext(os.path.basename(self.cs["reloadDBName"].lower()))[0],
	"Snapshot DB ({0}) and main DB ({1}) cannot have the same name."
	"Change name of settings file and resubmit.".format(
	self.cs["reloadDBName"], self.cs.caseTitle
	),
	"",
	self.NO_ACTION,
	)

This check tries to ensure that the snapshot DB and the current run name are not the same, presumably so that the old DB doesn't get overwritten.

This check does not account for the fact that the snapshot DB might be in a different directory, in which case there wouldn't be any issue and the warning is misguided.

[john-science]

This check does not account for the fact that the snapshot DB might be in a different directory, in which case there wouldn't be any issue and the warning is misguided.

Doesn't it?

In this line:

armi/armi/operators/settingsValidation.py

Line 452 in f9903fe

== os.path.splitext(os.path.basename(self.cs["reloadDBName"].lower()))[0],

The os.path.basename() gets the file name from the path.

[john-science]

We discussed, and our suggested change goes something like this:

1. Check the reloadDB path is not in the current directory, and that it is not a child current/working dir
   • (It would be nice if we could guarantee the case suite child naming.)
2. It can be in the current/working dir, if it has a different name than the caseTitle (this is the current check)

The only thing I'm not sure about is if we can get the "current working directory" safely in call cases in this lambda function.