-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check on snapshot DB name is not smart #1724
Comments
Doesn't it? In this line: armi/armi/operators/settingsValidation.py Line 452 in f9903fe
The |
We discussed, and our suggested change goes something like this:
The only thing I'm not sure about is if we can get the "current working directory" safely in call cases in this |
There is a settings validator that checks the name of the database being used in a snapshot run:
armi/armi/operators/settingsValidation.py
Lines 450 to 459 in f9903fe
This check tries to ensure that the snapshot DB and the current run name are not the same, presumably so that the old DB doesn't get overwritten.
This check does not account for the fact that the snapshot DB might be in a different directory, in which case there wouldn't be any issue and the warning is misguided.
The text was updated successfully, but these errors were encountered: