Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The test_axialExpansionChanger.py tests are too slow #1741

Open
john-science opened this issue Jun 20, 2024 · 0 comments
Open

The test_axialExpansionChanger.py tests are too slow #1741

john-science opened this issue Jun 20, 2024 · 0 comments
Assignees
Labels
low priority Style points and non-features optimization related to measuring and speeding up the code or reducing memory testing Related to tests

Comments

@john-science
Copy link
Member

The unit tests in test_axialExpansionChanger.py are the slowest in ARMI. For instance, these three tests alone take 30 seconds to run:

  • TestInputHeightsConsideredHot::test_coldAssemblyExpansion - 15.84 seconds
  • TestConservation::test_thermalExpansionContractionConservation_complex - 6.75 seconds
  • TestManageCoreMesh::test_manageCoreMesh - 6.08 seconds

Could we reduce the size of the detailed axial expansion test reactor? That is clearly the cause of the slowness:

- - SH
- SH SH
- SH OC SH
SH OC OC SH
OC MC OC SH
OC MC MC OC SH
MC MC MC OC SH
MC MC SC OC SH
MC PC MC MC OC SH
IC IC MC MC OC
IC IC MC MC SH
IC LA IC MC OC
IC IC SC MC SH
LA IC MC OC
IC IC IC MC SH
IC IC MC OC
AF IC IC PC SH

Do we really need a full 9-ring reactor to test that assemblies expand thermally, in the axial direction?

@john-science john-science added testing Related to tests optimization related to measuring and speeding up the code or reducing memory low priority Style points and non-features labels Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority Style points and non-features optimization related to measuring and speeding up the code or reducing memory testing Related to tests
Projects
None yet
Development

No branches or pull requests

2 participants