-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace tabulate
with prettytable
#1749
Comments
I have no particular love for People might get touchy that you change the formatting of their log tables. But, that's not a big change, so I'm okay with it. |
I'm not sure if replacing is necessary if See: |
@jakehader Update: sorry, it runs with python 3.11, but it doesnt work over pip 22.2 with setup.py installs, which is blocking us from upgrading. |
Thanks for the context. That wasn't in the discussion so I didn't know about an issue with pip or how it's blocking. |
True that! I think I must've offered the context in an offline chat before making the discussion. I'd need to retrace my steps to remember exactly how it's failing for us but it's something really lame |
Sounds good - I'm fine with it if there is an issue with I haven't used anything but |
will do. Just need time to get back to my python311 work. |
Would a fork of tabulate that includes bug fixes and supports newer Python versions help you, or is the move to prettytable the best solution? I ask because I and others have been thinking about forking into something like tabulate-ng. |
We want to move to a project that isn't deprecated and we can rely on updates being pushed to PyPI. Just helps keep things running over the longer term. |
Interestingly, I found the So I pulled the 2,800 line file out of that repo, and pulled it into an ARMI branch. It worked like a charm. I also found I could reduce it to 1,500 lines, as there are a ton of features we don't want. So... that might be an option. |
I'm a fan! either ingest it or fork it. Don't matter to me! |
Discussed in #1747
Originally posted by opotowsky June 25, 2024
tabulate
is a dead project andprettytable
is not. But it's pretty extensively used here and downstream with therunLog
module.NOTE: Because
tabulate
is a dead project, it is stopping us from moving to Python 3.11.The text was updated successfully, but these errors were encountered: