Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommendation to rename the puFrac parameter to puHMFrac and add block parameter puWeightFrac #1762

Open
sammiller11235 opened this issue Jul 3, 2024 · 2 comments
Labels
feature request Smaller user request

Comments

@sammiller11235
Copy link
Contributor

It can be seen below that the block parameter definition that puFrac represents the fraction of "heavy metal" which is Plutonium. For certain fuel systems, the plutonium in the fuel is typically defined as the total weight fraction of Plutonium in the fuel mass (e.g., 100 grams of U-19Pu-10Zr has 19g of Pu, 10g of Zr, and 71g of U). This parameter has been misinterpreted to mean the Pu total weight fraction, and renaming would resolve this ambiguity.

pb.defParam(
"puFrac",
units=units.UNITLESS,
description="Current Pu number density relative to HM at BOL",
location=ParamLocation.AVERAGE,
)

@onufer
Copy link
Member

onufer commented Jul 8, 2024

if we make the second param, we should probably call it puFuelWeightFrac

@john-science john-science added the feature request Smaller user request label Jul 11, 2024
@john-science
Copy link
Member

Renaming parameters is easy enough, my only caution is that we are in the middle of a particularly busy release right now.

Having said that, my request is that if we change the name of this parameter, we don't use the name puFrac for another other parameters. We've had some real tricky problems in the past when people think they are using one parameter, but it's become something totally different. If you follow me.

I'll leave it up to you two, if you think this is high enough priority to push through now, or if we wait 2-3 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Smaller user request
Projects
None yet
Development

No branches or pull requests

3 participants