Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to "import numpy as np" #1775

Closed
john-science opened this issue Jul 11, 2024 · 2 comments · Fixed by #1837
Closed

Move to "import numpy as np" #1775

john-science opened this issue Jul 11, 2024 · 2 comments · Fixed by #1837
Assignees
Labels
cleanup Code/comment cleanup: Low Priority good first issue Good for newcomers low priority Style points and non-features

Comments

@john-science
Copy link
Member

In 17 places in the repo we use the community standard numpy import:

import numpy as np

But in 69 places in the repo, we use the other import:

import numpy

This is Low Priority, but I prefer we be consistent. And, as a preference, I would prefer we us as np.

@john-science john-science added good first issue Good for newcomers cleanup Code/comment cleanup: Low Priority low priority Style points and non-features labels Jul 11, 2024
@MohitKambli
Copy link

Hello!
Hope you're doing well.
Could I possibly contribute to this issue too?
I literally got so involved in the issue, that I absolutely missed on giving an update to this ticket.
This is how the result of pytest command looks like for the files changes mentioned on the left:

image

I just hope these code changes met the necessary requirement as mentioned in the issue description above.
Extremely sorry if I missed something.
If at all there is a chance of a combined contribution, then that would be just fine as well.
My deepest apologies for the trouble being caused.

Thanks and Regards,
Mohit Kambli

@jakehader jakehader linked a pull request Jul 12, 2024 that will close this issue
7 tasks
@terrapower terrapower deleted a comment from NeuralNoble Jul 12, 2024
@jakehader
Copy link
Member

Hello! Hope you're doing well. Could I possibly contribute to this issue too? I literally got so involved in the issue, that I absolutely missed on giving an update to this ticket. This is how the result of pytest command looks like for the files changes mentioned on the left:

image

I just hope these code changes met the necessary requirement as mentioned in the issue description above. Extremely sorry if I missed something. If at all there is a chance of a combined contribution, then that would be just fine as well. My deepest apologies for the trouble being caused.

Thanks and Regards, Mohit Kambli

@MohitKambli - I think @NeuralNoble beat you to the changes and Pull Request - if you have additional comments on that pull request, you're welcome to make suggestions. Thanks for your general interest in helping out and please feel free to look at other open issues. Please let us know if you're interested in others and comment on them so we can either assign them to you first or provide additional clarity on the issue.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority good first issue Good for newcomers low priority Style points and non-features
Projects
None yet
4 participants