-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to "import numpy as np" #1775
Comments
Hello! I just hope these code changes met the necessary requirement as mentioned in the issue description above. Thanks and Regards, |
@MohitKambli - I think @NeuralNoble beat you to the changes and Pull Request - if you have additional comments on that pull request, you're welcome to make suggestions. Thanks for your general interest in helping out and please feel free to look at other open issues. Please let us know if you're interested in others and comment on them so we can either assign them to you first or provide additional clarity on the issue. Thanks! |
In 17 places in the repo we use the community standard numpy import:
armi/armi/utils/mathematics.py
Line 20 in 40c6d29
But in 69 places in the repo, we use the other import:
armi/armi/interfaces.py
Line 32 in 40c6d29
This is Low Priority, but I prefer we be consistent. And, as a preference, I would prefer we us
as np
.The text was updated successfully, but these errors were encountered: