Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Tool ARMI notebook tests as integration tests #1885

Open
john-science opened this issue Sep 16, 2024 · 0 comments
Open

Re-Tool ARMI notebook tests as integration tests #1885

john-science opened this issue Sep 16, 2024 · 0 comments
Assignees
Labels
architecture Issues related to big picture system architecture ci Related to continuous integration / github actions cleanup Code/comment cleanup: Low Priority testing Related to tests

Comments

@john-science
Copy link
Member

ARMI has two Jupyter Notebook tutorials, used in the docs, that are also run through as unit tests to make sure they still work:

class NotebookTests(unittest.TestCase):

ARMI is a framework, and without external physics kernels it cannot model a reactor. But these two notebooks represent the most external driving of ARMI that you can do without a fully-fledged ARMI application.

Some questions

  • Do we need a requirement that we run these notebooks as tests?
  • Do we rename this test class ArmiIntegrationTests?
  • Do we add more asserts to these tests?
@john-science john-science added architecture Issues related to big picture system architecture cleanup Code/comment cleanup: Low Priority testing Related to tests ci Related to continuous integration / github actions labels Sep 16, 2024
@john-science john-science self-assigned this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Issues related to big picture system architecture ci Related to continuous integration / github actions cleanup Code/comment cleanup: Low Priority testing Related to tests
Projects
None yet
Development

No branches or pull requests

1 participant