Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we want a commit hook that rejects badly named branches? #25

Open
fpdotmonkey opened this issue Aug 11, 2020 · 4 comments
Open

Do we want a commit hook that rejects badly named branches? #25

fpdotmonkey opened this issue Aug 11, 2020 · 4 comments
Assignees
Labels
question Further information is requested

Comments

@fpdotmonkey
Copy link
Collaborator

With tetrabiodistributed/tetra#50, we have a standard for branch names, i.e. [issue label]/[hyphen seperated description]-[issue number]. Do we want a commit hook that screams when someone makes a badly named branch?

@fpdotmonkey fpdotmonkey added the question Further information is requested label Aug 11, 2020
@fpdotmonkey
Copy link
Collaborator Author

things for this:

  • enforcing convention is good
  • it can be used to clearly convey what the convention is when developers care

@fpdotmonkey
Copy link
Collaborator Author

things against this:

  • I'm (at least for now) the only developer. I can probably maintain convention on my own
  • I'm told this kind of commit hook is annoying

@capsulecorplab
Copy link
Member

I was going to say... I think a commit hook would work for developers pushing via CLI, but idk if it also works on the GitHub UI - where I suspect people would be more inclined to break convention.

@fpdotmonkey fpdotmonkey self-assigned this Sep 13, 2020
@fpdotmonkey
Copy link
Collaborator Author

fpdotmonkey commented Jul 4, 2021

You might be able to add a pre-commit hook to the repo on github's servers, maybe something like scp pre-commit git@github.com:tetrabiodistributed/project-tetra-display/.git/hooks, but that's hacky as heck. Anyway branch naming might be better socially enforced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants