Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker commands setting option #3

Open
arthurgreef opened this issue Apr 19, 2020 · 1 comment · May be fixed by #7
Open

Add docker commands setting option #3

arthurgreef opened this issue Apr 19, 2020 · 1 comment · May be fixed by #7
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@arthurgreef
Copy link

Hi - it would be great if we could add additional docker commands when the extension runs rnode from a container. For example, I implemented the http extension you wrote and I would like to call a server running on the host machine. I can use http://host.docker.internal but I'd prefer to use http://127.0.0.1 as that is what I use when I deploy to my network that does not use containers. Thanks.

Use --network="host" in your docker run command, then 127.0.0.1 in your docker container will point to your docker host.

Note: This mode only works on Docker for Linux, per the documentation.

@tgrospic
Copy link
Owner

Hi Arthur! Your request totally makes sense. Even more the goal is to have another option for running RNode with the extension and this is just connecting to existing instance running externally where you have the full control.

Currently the main limitation (or complication) is that repl API can not give the output to the caller and also some parsing errors are written to standard output/error. This makes it much harder to create some simple interface to connection to external node.
My idea is to use something like .rholangrc file which can serve as project based configuration for editors and other tools where we can have much more freedom and customization options. Extension should be as thin as possible so that we can use it on the web with the same experience.

For now, I'll add new settings option to enter additional Docker run command arguments. 👍

@tgrospic tgrospic self-assigned this Apr 21, 2020
@tgrospic tgrospic added enhancement New feature or request good first issue Good for newcomers labels Apr 21, 2020
@tgrospic tgrospic linked a pull request Jun 24, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants