Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading holidays twice ignores conflicts and generates duplicate entries #1008

Open
araujoarthur0 opened this issue Oct 7, 2023 · 1 comment · Fixed by #1011
Open

Loading holidays twice ignores conflicts and generates duplicate entries #1008

araujoarthur0 opened this issue Oct 7, 2023 · 1 comment · Fixed by #1011
Labels
bug Something isn't working hacktoberfest Hacktoberfest
Milestone

Comments

@araujoarthur0
Copy link
Collaborator

Describe the issue
When there are conflicts in sourcing holidays, we are not clear on the message.
The duplicates remain in the table after clicking, but disappear after closing the window.

To Reproduce
Steps to reproduce the behavior:

holidays

Once you open again, they are overriden, they just seem like they were duplicated in the table.

Expected behavior

  1. We can override them, but we should inform the user when they click on "Source selected holidays" if there's a conflict, and wait until they choose "yes".
  2. There should not be duplicates on the table after selecting.

Environment

Version: 3.0.1-dev
Electron: 11.5.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
OS: Windows_NT x64 10.0.22621

@araujoarthur0
Copy link
Collaborator Author

Now the checkboxes are properly set.
But it would still be interesting to have a pop-up alert when one ignores the conflict and unchecks it.

@thamara thamara added this to the Next version milestone Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants