Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to electron 28 as soon as it releases - stop using esm #1037

Open
araujoarthur0 opened this issue Nov 3, 2023 · 2 comments · May be fixed by #1054
Open

Update to electron 28 as soon as it releases - stop using esm #1037

araujoarthur0 opened this issue Nov 3, 2023 · 2 comments · May be fixed by #1054
Labels
enhancement New feature or request

Comments

@araujoarthur0
Copy link
Collaborator

Electron 28 will bring the promised support to ES modules: electron/electron#21457

Important

Support for ES Modules in Electron will land in Electron 28 and will be available in the electron-nightly released on August 31st
🥳

After that, maybe we'll be able to stop using the esm module to mix require and import statements?
@araujoarthur0 araujoarthur0 added the enhancement New feature or request label Nov 3, 2023
@araujoarthur0
Copy link
Collaborator Author

Here it is: https://releases.electronjs.org/release/v28.0.0

This was referenced Jan 7, 2024
Merged
Draft
This was referenced Jan 25, 2024
Merged
Merged
@araujoarthur0
Copy link
Collaborator Author

We have to migrate tests to mocha since jest-electron is no longer mantained and jest doesn't play nice with es6 modules.

This was referenced Jan 30, 2024
Merged
Merged
This was referenced Mar 9, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Migrating to Electron 28 araujoarthur0/time-to-leave
1 participant
@araujoarthur0