Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization action is broken somehow #829

Open
thamara opened this issue Mar 10, 2022 · 4 comments
Open

Localization action is broken somehow #829

thamara opened this issue Mar 10, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@thamara
Copy link
Owner

thamara commented Mar 10, 2022

In #828 the Localization action is broken. This action is used to compare if new strings are added or any inconsistency on the localization files.

Run: https://github.com/thamara/time-to-leave/runs/5490690174?check_suite_focus=true

@thamara thamara added the bug Something isn't working label Mar 10, 2022
@ochan12
Copy link
Contributor

ochan12 commented Nov 4, 2022

I think is because the action is configured to run on pull_request so secrets are not sent to forked repos, as said here. On PRs coming from own repo seems to work.

It could be changed to pull_request_target so the context comes from the base branch and not forked one

@tupaschoal
Copy link
Collaborator

That's a good point, maybe we should try that @thamara

@araujoarthur0
Copy link
Collaborator

Disabled the action to stop having failed runs on every PR.

@araujoarthur0
Copy link
Collaborator

Like ochan12 said, seem this was documented in the action repo:

create-or-update-comment@v2

Note: In public repositories this action does not work in pull_request workflows when triggered by forks. Any attempt will be met with the error, Resource not accessible by integration. This is due to token restrictions put in place by GitHub Actions. Private repositories can be configured to enable workflows from forks to run without restriction. See here for further explanation. Alternatively, use the pull_request_target event to comment on pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants