Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature to reset preferences #891

Open
araujoarthur0 opened this issue Oct 26, 2022 · 7 comments
Open

Feature to reset preferences #891

araujoarthur0 opened this issue Oct 26, 2022 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@araujoarthur0
Copy link
Collaborator

Just like we have a menu button to clear the database, I wish we had a way to reset the preferences to the default value through the UI.
Maybe on the preferences page, or even a menu button.

@araujoarthur0 araujoarthur0 added the enhancement New feature or request label Oct 26, 2022
@sisir-umich
Copy link

Hi @araujoarthur0 can you assign this to me? If it isn't a high-priority task, I can work on this through November with my partner.

@araujoarthur0
Copy link
Collaborator Author

Sure, thanks.

@show981111
Copy link
Contributor

Hi, @araujoarthur0 can you assign this to me too? Sisir and I are planning to work together.

@araujoarthur0
Copy link
Collaborator Author

Done!

@sisir-umich
Copy link

sisir-umich commented Nov 17, 2022

Hi @araujoarthur0 - I have a quick question.

We implemented the reset preferences button now, and it successfully changes the preferences after closing the preferences window (the main app has the changes immediately). However, the changes in the UI and sliders don't render in the preferences window itself, but they appear once the preferences window is reloaded.

Should the preferences window also immediately reflect the changes after the preferences get reset, or is it better to allow that after re-opening the window?

@tupaschoal
Copy link
Collaborator

I'd say it should reflect the changes immediately, but if that is too hard, maybe we pop-up that "preferences have been reset" and then upon closing the pop-up the preferences window closes? Then the user upon reopening would see them on their default value. It's not the best solution, but it is a stopgap if it's too difficult to update it live.

@sisir-umich
Copy link

sisir-umich commented Nov 19, 2022

Thanks for the suggestion! We'll try to implement it to show the immediate changes, and then we'll look into the second option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants