Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't profile performance #24

Open
jayenashar opened this issue Oct 20, 2018 · 2 comments
Open

can't profile performance #24

jayenashar opened this issue Oct 20, 2018 · 2 comments

Comments

@jayenashar
Copy link

i tried to profile the performance on my computer to see if i could help speed things up. i recall before i could clearly see that a lot of time was going to papaparse, but now i can't. all the time in the main thread seems to be going to appendChild (even though it hasn't finished parsing) and all the time in the worker thread seems to be going to garbage collection. can you help me get the profiler going again, so i can help improve the performance?

the line numbers are all screwy, too. everything is either object-assign/index.js:9 or localForage.js:7

@thatsmydoing
Copy link
Owner

I don't really know what's up with the sourcemaps. I can take a look but it might take a while.

I'm not sure if performance can be improved much, a lot of it is probably the validation and not the parsing though.

@jayenashar
Copy link
Author

ok, no worries. not sure when i'll have time again to look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants