Add VIA support for Keychron C2 Pro #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add VIA support for Keychron C2 Pro
|
These definitions don't work for me. Please look for my fix |
|
@lalalademaxiya1 ^ |
Update json file of c2_pro ansi white version
|
@asmbk Hi, after comparison, there are indeed errors in the this file, corrected it now, Thanks! |
|
@Xelus22 Hi, corrected it. Thanks! |
Deleteed ESC label
Xelus22
approved these changes
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added VIA JSONs for Keychron C2 Pro and request for a review, Thanks!
Description
QMK Pull Request
qmk/qmk_firmware#20701
Checklist
0xFEED