Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rocketkeyboards Mercury65 #1931

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add Rocketkeyboards Mercury65 #1931

wants to merge 5 commits into from

Conversation

drewpyun
Copy link
Contributor

@drewpyun drewpyun commented Jul 5, 2023 •
edited
Loading

Requesting to add board Mercury65 made by Rocketkeyboards
QMK PR #20811
Tested on usevia.app

Description

QMK Pull Request

QMK PR #20811

qmk/qmk_firmware#20811

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@drewpyun drewpyun marked this pull request as ready for review September 15, 2023 00:27
Xelus22
Xelus22 requested changes Sep 17, 2023
View reviewed changes
Copy link
Collaborator

@Xelus22 Xelus22 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove V2 definition (src/ folder) json. It is only for legacy boards.

drewpyun
drewpyun commented Sep 18, 2023
View reviewed changes
Copy link
Contributor Author

@drewpyun drewpyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted mercury65 in src/ per request

Xelus22
Xelus22 requested changes Sep 23, 2023
View reviewed changes
Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.caniusevia.com/docs/layouts#kle-json-rules

please colour in your KLE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drewpyun @Xelus22