Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mechstudio/Chapter1 #2233

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Conversation

casuanoob
Copy link
Contributor

@casuanoob casuanoob commented Apr 11, 2024

Description

Add support for Chapter 1 by Rooke Design.

This is an exploded 65% design with an encoder in the top right. Solder and hotswap variants are handled on the same firmware.

I've also moved mechstudio/dawn.json to mechstudio/dawn/dawn.json for neatness. Not sure if the convention is to have a subdirectory for each keyboard or if the defintions can just all sit in the vendor directory.

QMK Pull Request

PR merged: #23452

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@casuanoob casuanoob marked this pull request as ready for review April 12, 2024 06:27
@Cipulot
Copy link
Collaborator

Cipulot commented Apr 12, 2024

@casuanoob thanks for the PR. The move you performed by having separate keyboard folders under the vendor name is the type of formatting we will apply from now on. It's mainly for those boards that have a lot of sub versions but, for consistency, the scheme should be followed by a 1 version board too.
Thanks for applying the change directly yourself 👍

@Cipulot Cipulot merged commit dca127e into the-via:master Apr 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants