Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create shadow80.json #2245

Merged
merged 4 commits into from
Apr 28, 2024
Merged

Create shadow80.json #2245

merged 4 commits into from
Apr 28, 2024

Conversation

Vem-596
Copy link
Contributor

@Vem-596 Vem-596 commented Apr 18, 2024

add shadow80 json

adding shadow80 via support

Description

Added the shadow80 JSON to the herevoland folder

QMK Pull Request

qmk/qmk_firmware#22534

Checklist

  • [x ] The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • [x ] The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • [x ] I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • [x ] I have tested this keyboard definition using VIA's "Design" tab.
  • [x ] I have tested this keyboard definition with firmware on a device.
  • [x ] I have assigned alpha keys and modifier keys with the correct colors.
  • [x ] The Vendor ID is not 0xFEED

@Cipulot
Copy link
Collaborator

Cipulot commented Apr 18, 2024

The board is not in QMK, there's no link, nothing. Closing this one since it doesn't follow any of the PR formatting nor the rules...

@Cipulot Cipulot closed this Apr 18, 2024
@Vem-596
Copy link
Contributor Author

Vem-596 commented Apr 19, 2024

该板不在 QMK 中,没有链接,什么都没有。关闭这个,因为它不遵循任何 PR 格式或规则......
It has been added link now.Sorry for the trouble.

@Cipulot Cipulot reopened this Apr 19, 2024
@Cipulot
Copy link
Collaborator

Cipulot commented Apr 19, 2024

@Vem-596 the path for the json should be v3/pixelspace/shadow80/shadow80.json and not v3/herevoland/shadow80.json, since it should match the QMK one.

Change the path.

@Cipulot
Copy link
Collaborator

Cipulot commented Apr 19, 2024

And please.... follow a bot of order in the doc guidelines and don't squish layout options one on top of each other like if they are layers on a sandwich....
Like..... what is this...

Rework the file to have the path change and follow the proper guidelines. Till then the PR is not gonna be merged

Screenshot 2024-04-19 at 10 33 40 AM

@Cipulot Cipulot added the needs work The PR needs fixes/ things need to be addressed label Apr 19, 2024
@Vem-596 Vem-596 closed this Apr 22, 2024
@Vem-596 Vem-596 reopened this Apr 22, 2024
@Vem-596 Vem-596 closed this Apr 22, 2024
@Vem-596 Vem-596 reopened this Apr 22, 2024
@Vem-596
Copy link
Contributor Author

Vem-596 commented Apr 23, 2024

@Cipulot Please help check the document for its feasibility. Thank you very much!

v3/pixelspace/shadow80/shadow80.json Outdated Show resolved Hide resolved
@Cipulot Cipulot merged commit 086767f into the-via:master Apr 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs work The PR needs fixes/ things need to be addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants