Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[database] Add MongoDB support (but leave fiat-based DB intact) #125

Open
ajhalili2006 opened this issue Jun 25, 2020 · 4 comments
Open

Comments

@ajhalili2006
Copy link

ajhalili2006 commented Jun 25, 2020

About this Issue

This will resolves #91 for Heroku users who hates getting some add-ons to support persistent storage. This will also lessen the hassle of moving between servers. While @trgwii don't want to burden us with installing MongoDB (or looking on where we can host our MongoDB instances to use this lightweight bot) and this may make an Raspberry Pi rekt if we self-host MongoDB there, I would like to leave the fiat-based DB intact so advanced users can migrate/use to MongoDB without being limited by the filesystem.

Related card from project's mainboard

@trgwii
Copy link
Member

trgwii commented Jul 27, 2020

We don't want to burden our users with installing MongoDB in order to use this relatively lightweight bot. Currently this bot can run fine on a Raspberry Pi, that would not be the case if we migrated to Mongo.

@trgwii trgwii closed this as completed Jul 27, 2020
@MKRhere
Copy link
Member

MKRhere commented Jul 27, 2020

If we decoupled the database logic, we'd be able to allow some heavy users to use/migrate to Mongo while keeping nedb support. Because nedb and Mongo are very similar, it might not be too difficult to have a layer of indirection. It'll also allow the users who want to use a PaaS like Heroku (#91) to run the bot without being limited by fs.

I'd say it's not a priority, but we can leave this ticket open for now.

@MKRhere MKRhere reopened this Jul 27, 2020
@faizanakram99
Copy link
Member

I was about to say the same, database layer should be abstracted so that we can easily switch between various document databases

@ajhalili2006
Copy link
Author

Based on the feedback @MKRhere and @faizanakram99 posted earlier, I would agree to keep the nedb support even there's MongoDB. I'll update the title and description of this issue to reflect these changes.

@ajhalili2006 ajhalili2006 changed the title [database] Use MongoDB by default [database] Use MongoDB by default (but leave fiat-based DB intact) Jul 29, 2020
@ajhalili2006 ajhalili2006 changed the title [database] Use MongoDB by default (but leave fiat-based DB intact) [database] Add MongoDB support (but leave fiat-based DB intact) Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants