From b0ad91808e80d4615159ce219346ac6f02bcd725 Mon Sep 17 00:00:00 2001 From: Jay Lee Date: Tue, 5 Nov 2024 01:48:24 -0800 Subject: [PATCH] Update fairspace-ingress.yaml to allow pathType override ImplementationSpecific will break the intended functionality or ingress providers which do not default to prefix matching, such as the AWS ALB. --- charts/fairspace/templates/ingress/fairspace-ingress.yaml | 2 +- charts/fairspace/values.yaml | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/charts/fairspace/templates/ingress/fairspace-ingress.yaml b/charts/fairspace/templates/ingress/fairspace-ingress.yaml index 2ce9380e74..9da2196d1a 100644 --- a/charts/fairspace/templates/ingress/fairspace-ingress.yaml +++ b/charts/fairspace/templates/ingress/fairspace-ingress.yaml @@ -23,7 +23,7 @@ spec: http: paths: - path: / - pathType: ImplementationSpecific + pathType: {{ $ingress.pathType | default "ImplementationSpecific" }} backend: service: name: {{ .Release.Name }} diff --git a/charts/fairspace/values.yaml b/charts/fairspace/values.yaml index 7979ed5dc5..cfb8a36e81 100644 --- a/charts/fairspace/values.yaml +++ b/charts/fairspace/values.yaml @@ -13,12 +13,15 @@ external: clientSecret: # Setup ingress for fairspace components +# Change pathType to "Prefix" for ingress providers which do not default to prefix or wildcard +# matching for the "/" path, eg: AWS ALB fairspace: name: "fairspace" description: "Fairspace" ingress: enabled: true domain: + pathType: ImplementationSpecific annotations: pluto: kubernetes.io/ingress.class: nginx @@ -185,4 +188,4 @@ postgres: # Pod annotations should remain empty. They are filled within the build process podAnnotations: { } -svgicons: { } \ No newline at end of file +svgicons: { }