Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules_uv for Windows #104

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

rules_uv for Windows #104

wants to merge 8 commits into from

Conversation

classner
Copy link

This PR adds changes and functionality to make rules_uv work seamlessly on Windows. It does not make any additional assumptions about the environment (i.e., runs in regular windows batch or powershell, as well as msys2) - one limitation that I have not found a way around is the requirement for the create_venv targets to be named in a way that they are recognized as executable scripts by Windows (.cmd or .bat).

Let me know what you think!

@classner classner requested review from reviewbot-theorem and a team as code owners August 10, 2024 22:56
@mark-thm
Copy link
Collaborator

@classner thanks for your work! In thinking about easing support for this, I'm tempted to turn rules_uv into a build action w/ a write_source_files target that's runnable to copy built files into the source tree. The gain of that would be getting rid of the bash (and new batch) scripts as we can have Bazel run the toolchain directly. It's been on my backburner to restructure things in this way, hoping to get to it in the next couple of weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants