Skip to content

Commit

Permalink
soundwire: cadence: enable interrupts after the clock restarts
Browse files Browse the repository at this point in the history
For some reason, we don't have a symmetry between clock stop and clock
start. We should disable the interrupts first on clock stop, and
re-enable them last on clock restart.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
  • Loading branch information
plbossart committed Jun 17, 2024
1 parent 26e53b1 commit 3e8b6f5
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/soundwire/cadence_master.c
Original file line number Diff line number Diff line change
Expand Up @@ -1713,9 +1713,6 @@ int sdw_cdns_clock_restart(struct sdw_cdns *cdns, bool bus_reset)
{
int ret;

/* unmask Slave interrupts that were masked when stopping the clock */
cdns_enable_slave_interrupts(cdns, true);

ret = cdns_clear_bit(cdns, CDNS_MCP_CONTROL,
CDNS_MCP_CONTROL_CLK_STOP_CLR);
if (ret < 0) {
Expand Down Expand Up @@ -1753,6 +1750,9 @@ int sdw_cdns_clock_restart(struct sdw_cdns *cdns, bool bus_reset)
dev_err(cdns->dev, "bus failed to exit clock stop %d\n", ret);
}

/* unmask Slave interrupts that were masked when stopping the clock */
cdns_enable_slave_interrupts(cdns, true);

return ret;
}
EXPORT_SYMBOL(sdw_cdns_clock_restart);
Expand Down

0 comments on commit 3e8b6f5

Please sign in to comment.