ASoC: SOF: Intel: always check the result of acpi_dev_get_first_match… #5117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plbossart
requested review from
lgirdwood,
ranj063,
kv2019i,
dbaluta,
bardliao and
ujfalusi
as code owners
|
sof_wm8804.c is missed. adev = acpi_dev_get_first_match_dev(mach->id, NULL, -1); |
plbossart
force-pushed
the
fix/acpi_dev_get_first_match_dev_check
branch
from
fd47a63
to
c7b35fb
Compare
indeed, thanks for noticing @bardliao. Fixed now. |
bardliao
approved these changes
Jul 24, 2024
ujfalusi
approved these changes
Jul 24, 2024
…tch_dev() The code seems mostly copy-pasted, with some machine drivers forgetting to test if the 'adev' result is NULL. Add this check when missing, and use -ENOENT consistently as an error code. Link: https://lore.kernel.org/alsa-devel/918944d2-3d00-465e-a9d1-5d57fc966113@stanley.mountain/T/#u Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart
force-pushed
the
fix/acpi_dev_get_first_match_dev_check
branch
from
c7b35fb
to
cdd1206
Compare
|
updated commit title, no code change. |
plbossart
merged commit 96ffc59
into
thesofproject:topic/sof-dev
11 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…_dev()
The code seems mostly copy-pasted, with some machine drivers forgetting to test if the 'adev' result is NULL.
Add this check when missing, and use -ENOENT consistently as an error code.
Link: https://lore.kernel.org/alsa-devel/918944d2-3d00-465e-a9d1-5d57fc966113@stanley.mountain/T/#u
Reported-by: Dan Carpenter dan.carpenter@linaro.org