ASoC: Intel: soc-acpi-intel-arl-match: Add rt722 and rt1320 support #5187
Conversation
This patch adds support for the rt722 multi-function codec and the rt1320 amplifier in the ARL board configuration. Link 0: RT722 codec with three endpoints: Headset, Speaker, and DMIC. Link 2: RT1320 amplifier. Note: The Speaker endpoint on the RT722 codec is not used. Signed-off-by: Mac Chiang <mac.chiang@intel.com>
| .aggregated = 0, | ||
| .group_position = 0, | ||
| .group_id = 0, | ||
| }, |
There was a problem hiding this comment.
We need to remove the Speaker endpoint if it is not used.
There was a problem hiding this comment.
yeah, but there's no way to know is the speaker on the RT1320 is the only one in the system, or if it's used as a companion to that of the RT722.
The notion of endpoint was already not super useful and mostly introduced as a way to predict the future with audio composition, but it's already obsolete in that endpoints are now optional.... We'd need to check if the functions are described in ACPI for sure.
There was a problem hiding this comment.
@plbossart Can you take a look at #5188?
There was a problem hiding this comment.
@charleskeepax has a good suggestion on #5186 that can make a DAI be optional and present by default.
There was a problem hiding this comment.
@charleskeepax has a good suggestion on #5186 that can make a DAI be optional and present by default.
@bardliao, thank you for your advice. By referencing @charleskeepax #5186 suggestion on cs42l43, I could apply the quirk_exclude codes into RT722 as a short-term once #5186 merged. In the end, #5188 implementing the "endpoints present by sdca acpi function" will be a final solution afterwards.
This patch adds support for the rt722 multi-function codec and the rt1320 amplifier in the ARL board configuration.
Link 0: RT722 codec with three endpoints: Headset, Speaker, and DMIC.
Link 2: RT1320 amplifier.
Note:
The Speaker endpoint on the RT722 codec is not used.