Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] show WARN_ON() results #774

Open
plbossart opened this issue Sep 29, 2021 · 2 comments
Open

[FEATURE] show WARN_ON() results #774

plbossart opened this issue Sep 29, 2021 · 2 comments
Labels
area:logs Log and results collection, storage, etc. False Pass / green failure P2 Critical bugs or normal features type:bug Something doesn't work as expected

Comments

@plbossart
Copy link
Member

Is your feature request related to a problem? Please describe.

So far sof-test only reports the errors. It would be useful to show this type of warnings, which clearly point to something very wrong.

[  562.418115] kernel: WARNING: lock held when returning to user space!
[  562.418117] kernel: 5.15.0-rc1-pr3186-6452-nocodec #6d37c52e Not tainted
[  562.418120] kernel: ------------------------------------------------
[  562.418122] kernel: aplay/8747 is leaving the kernel with locks still held!
[  562.418125] kernel: 1 lock held by aplay/8747:
[  562.418127] kernel:  #0: ffffffffc07673e0 (&card->dpcm_mutex){....}-{3:3}, at: dpcm_be_dai_trigger+0x3da/0x4d0 [snd_soc_core]

Describe the solution you'd like

these lines shown in the output of sof-test scripts and an error status. Maybe in some cases we'll see false positives but we can filter them out

Describe alternatives you've considered
stop on warnings would be too invasive?

@marc-hb
Copy link
Collaborator

marc-hb commented Oct 1, 2021

One problem is neither github nor Jenkins (nor Travis) supports any intermediate "warning" level. It's either PASS or FAIL and nothing available in between. Binary like cable news and social media.

Right now success is based on journalctl -k --priority=err. We can certainly run journalctl -k --priority=warn too but then what do we do with the output? In which place(s) would like this to be displayed and how?

@plbossart
Copy link
Member Author

well that's precisely why I asked, I don't know how to do it.
if we report all the warnings we'll fail all the time. maybe filter and only allow the warnings when we see a pattern of WARNING with a kernel version below and the ---- delimiter.

@marc-hb marc-hb added type:bug Something doesn't work as expected P2 Critical bugs or normal features area:logs Log and results collection, storage, etc. labels Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:logs Log and results collection, storage, etc. False Pass / green failure P2 Critical bugs or normal features type:bug Something doesn't work as expected
Projects
None yet
Development

No branches or pull requests

2 participants