Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] report backtraces and warnings as errors #833

Open
plbossart opened this issue Jan 11, 2022 · 2 comments
Open

[FEATURE] report backtraces and warnings as errors #833

plbossart opened this issue Jan 11, 2022 · 2 comments
Labels
area:logs Log and results collection, storage, etc. False Pass / green failure P1 Blocker bugs or important features

Comments

@plbossart
Copy link
Member

Is your feature request related to a problem? Please describe.

thesofproject/linux#3362 describes a case where there are at least 3 developers reproducing a problem we have not seen in CI.

This could be due to the fact that 'warnings' are not trapped by our scripts, or that somehow we have not tested in the same condition. I will assume it's the former case for now.

Describe the solution you'd like

We can have different levels:

report backtraces as errors and filter if the issues are not due to SOF
report all warnings and filter if the issues are not due to SOF

Describe alternatives you've considered
I don't see any.

Additional context
Our CI/validation will not be trusted if we end-up polluting the mainline kernel with warnings that are not detected. This is not a drill, we need to fix this.

@plbossart
Copy link
Member Author

Adding kernel maintainers for feedback @kv2019i @ujfalusi @ranj063 @bardliao

@bardliao
Copy link
Contributor

I vote for the first level. ie. report backtraces as errors and filter if the issues are not due to SOF.
People don't like to see any backtraces. Regarding warnings, I am wondering how many warnings will be seen with current code base. We may filter the issues not due to SOF, but I can expect that we will often see new warnings after doing upstream merge.

@marc-hb marc-hb added area:logs Log and results collection, storage, etc. P1 Blocker bugs or important features labels Jun 22, 2023
@marc-hb marc-hb self-assigned this Jun 22, 2023
@marc-hb marc-hb removed their assignment May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:logs Log and results collection, storage, etc. False Pass / green failure P1 Blocker bugs or important features
Projects
None yet
Development

No branches or pull requests

3 participants