Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Filter out NVME harmless issues #888

Open
plbossart opened this issue Apr 11, 2022 · 6 comments
Open

[BUG] Filter out NVME harmless issues #888

plbossart opened this issue Apr 11, 2022 · 6 comments
Labels
area:non-audio Failure False positives: failing when we don't want to P3 Low-impact bugs or features type:bug Something doesn't work as expected

Comments

@plbossart
Copy link
Member

plbossart commented Apr 11, 2022 •
edited by marc-hb
Loading

https://sof-ci.01.org/linuxpr/PR3576/build7525/devicetest/

Suspend-resume is broken because of harmless NVME issues discussed here: https://lore.kernel.org/linux-nvme/F2ACCD82-052F-473F-9882-1703147FA662@oracle.com/T/#m14a43e0c73c589876d0cf20680c792e8d2ef5063

We should temporarily filter out this error to proceed with 5.18-rcX support

[  894.167961] kernel: nvme0: Admin Cmd(0x6), I/O Error (sct 0x0 / sc 0x2)
[   25.603110] kernel: nvme0: Admin Cmd(0x2), I/O Error (sct 0x0 / sc 0x2)

@marc-hb EDIT: this message appears at boot too, no need to test suspend/resume.
@plbossart plbossart added the bug label Apr 11, 2022
plbossart added a commit to plbossart/sof-test that referenced this issue Apr 11, 2022
@plbossart
sof-kernel-log-check: temporarily filter out NVME harmless issues
96032e8 
kernel 5.18-rc1 added a set of harmless NVME errors that we should
filter out until removed upstream.

BugLink: thesofproject#888
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@plbossart plbossart mentioned this issue Apr 11, 2022
Merged
marc-hb pushed a commit that referenced this issue Apr 12, 2022
@plbossart @marc-hb
sof-kernel-log-check: temporarily filter out NVME harmless issues
199ddeb 
kernel 5.18-rc1 added a set of harmless NVME errors that we should
filter out until removed upstream.

BugLink: #888
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@marc-hb
Copy link
Collaborator

marc-hb commented Apr 12, 2022 •
edited
Loading

Merged. Close? Passing now?

@plbossart
Copy link
Member Author

Merged. Close? Passing now?

no results that I can see.

Well I can see them if I use the private link https://sof-ci.sh.intel.com/#/result/planresultdetail/11758 but the SOF CI doesn't show the results publicly.

@marc-hb
Copy link
Collaborator

marc-hb commented Apr 13, 2022

We have some kind of outage right now because Github is rate-limiting us. Investigation in prgoress.

@plbossart
Copy link
Member Author

https://sof-ci.01.org/linuxpr/PR3785/build446/devicetest/?model=TGLU_UP_HDA&testcase=check-suspend-resume-with-playback-5

===========================>>
[ 1013.347888] kernel: nvme nvme0: Device shutdown incomplete; abort shutdown
<<===========================

@marc-hb
Copy link
Collaborator

marc-hb commented Jul 25, 2022

As usual a reminder to please make sure storage error messages are actually harmless before filtering them out. thesofproject/linux#3387 and friends cost us literally months of work, especially @keqiaozhang and @fredoh9's time. Who knows, maybe some of that time could have been saved by paying more attention to error messages?

@marc-hb marc-hb added area:storage area:non-audio Failure False positives: failing when we don't want to labels Jul 25, 2022
@marc-hb marc-hb added type:bug Something doesn't work as expected and removed bug labels May 17, 2023
@marc-hb
Copy link
Collaborator

marc-hb commented Jun 22, 2023

I believe this has been fixed, please re-open if not.

@marc-hb marc-hb added the P3 Low-impact bugs or features label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:non-audio Failure False positives: failing when we don't want to P3 Low-impact bugs or features type:bug Something doesn't work as expected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@plbossart @marc-hb