Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Remove buffer core ID from topology viewer #925

Open
ranj063 opened this issue Jun 28, 2022 · 3 comments
Open

[BUG] Remove buffer core ID from topology viewer #925

ranj063 opened this issue Jun 28, 2022 · 3 comments
Assignees
Labels
P3 Low-impact bugs or features type:bug Something doesn't work as expected

Comments

@ranj063
Copy link
Contributor

ranj063 commented Jun 28, 2022

Describe the bug
Buffer's are shown to be on Core: 0 in the topology viewer. They are passive components and do not have a core associated with them. It is confusing for people to see buffers and components in the same pipeline to have different core ID's

To Reproduce
Just view the topology graph for the sof-cavs-nocodec.tplg
https://sof-ci.01.org/sofpr/PR5958/build751/devicetest/?model=ADLP_RVP_NOCODEC&testcase=check-playback-10sec

Expected behavior
Buffers show no core ID

@ranj063 ranj063 added the bug label Jun 28, 2022
@miRoox
Copy link
Contributor

miRoox commented Jul 1, 2022

I think it's because those buffer components (like BUF7.0, BUF11.0, etc.) actually contain the element with token SOF_TKN_COMP_CORE_ID. If the component doesn't contain the core ID data, the graph won't show it, like BUF1.0, BUF2.1, etc. Therefore, I think the better way is to remove the core ID data from buffer components.

It seems there are some historic reasons to allocate buffers on core 0 thesofproject/sof#5097. If it's unacceptable to remove buffer core ID from the source code, I can add an exception for the buffer components in the topology graph.

@marc-hb marc-hb added type:bug Something doesn't work as expected and removed bug labels May 17, 2023
@marc-hb
Copy link
Collaborator

marc-hb commented Jun 22, 2023

@marc-hb marc-hb added the P3 Low-impact bugs or features label Jun 22, 2023
@marc-hb
Copy link
Collaborator

marc-hb commented Aug 13, 2024

@ranj063 is this still an issue? If yes can you share a link to a more recent example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Low-impact bugs or features type:bug Something doesn't work as expected
Projects
None yet
Development

No branches or pull requests

3 participants